Opened 4 weeks ago

Closed 4 weeks ago

#1850 closed Bug/Fehler (fixed)

strlen in xtc_show_category.inc.php

Reported by: noRiddle Owned by: somebody
Priority: normal Milestone: modified-shop-2.0.5.2
Component: Template Version: 2.0.5.1

Description

In der /templates/THE_TEMPLATE/source/inc/xtc_show_category.inc.php gibt es diese Zeile Code:

$categories_string = substr($categories_string, 0, strlen($categories_string) -5);  //letztes  </li>  entfernen 

Ich denke, daß entweder mb_strlen() (inkl. Angabe des Encodings) benutzt werden sollte oder, besser, schlicht dies:

$categories_string = substr($categories_string, 0, -5);  //letztes  </li>  entfernen 

Da strlen() oder auch mb_strlen() ohnehin unnötig ist würde das auch einen kleinen Performance-Vorteil bringen.

Analog kann die Sache auch in der xtc_show_content.inc.php korrigiert werden.

Gruß,
noRiddle

Attachments (0)

Change History (2)

comment:1 Changed 4 weeks ago by Tomcraft

  • Component changed from Shop to Template

comment:2 Changed 4 weeks ago by GTB

  • Resolution set to fixed
  • Status changed from new to closed

In 12822:

fix #1850 - removed unnecessary use of function strlen()

Add Comment

Modify Ticket

Action
as closed
The resolution will be deleted. Next status will be 'reopened'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.