Opened 13 months ago

Closed 7 months ago

Last modified 5 weeks ago

#1711 closed Erweiterung (fixed)

Mehrsprachiges Shopvote & Produktbewertungen, Update notwendig

Reported by: noRiddle Owned by: somebody
Priority: normal Milestone: modified-shop-2.0.6.0
Component: Module Version: trunk

Description (last modified by Tomcraft)

Aufgrund dessen, daß Shopvote nun mehrsprachig ist könnte/sollte/müsste es eine Anpassung des System-Modules bzgl. var myLanguage geben.
Siehe dazu bitte diesen Post. Mein Vorschlag in dem verlinkten Post ist nur ein vorrübergehender work-around ohne Kenntnisse dessen, was Ihr mit Shopvote für Absprachen treffen können könntet :-D.

Zusätzlich Erweiterung für Produktbewertungen, siehe: NEU: Produktbewertungen sammeln mit SHOPVOTE

Gruß,
noRiddle

Attachments (10)

changeset_12701.zip (6.5 KB) - added by Tomcraft 8 months ago.
changeset_12707.zip (1.1 KB) - added by Tomcraft 7 months ago.
changeset_12710.zip (2.5 KB) - added by Tomcraft 7 months ago.
changeset_12712.zip (2.6 KB) - added by Tomcraft 7 months ago.
changeset_12713.zip (2.5 KB) - added by Tomcraft 7 months ago.
changeset_12714.zip (5.4 KB) - added by Tomcraft 7 months ago.
changeset_12718.zip (4.2 KB) - added by Tomcraft 7 months ago.
changeset_12719.zip (1.3 KB) - added by Tomcraft 7 months ago.
changeset_12727.zip (1.4 KB) - added by Tomcraft 7 months ago.
changeset_12752.zip (1.5 KB) - added by Tomcraft 7 months ago.

Download all attachments as: .zip

Change History (32)

comment:1 Changed 13 months ago by Tomcraft

  • Component changed from Admin to Module
  • Description modified (diff)
  • Summary changed from Mehrsprachiges Shopvote, Update notwendig to Mehrsprachiges Shopvote & Produktbewertungen, Update notwendig
  • Type changed from Bug/Fehler to Erweiterung
  • Version set to trunk

comment:2 Changed 12 months ago by FräuleinGarn

Vielleicht wäre es auch möglich die Bewertungen nur einmal am Tag abzurufen und den Rest zu cachen, dass nicht bei jedem Seitenaufruf die 18 Skripte und Grafiken geladen werden müssen, die sich in der einen aufzurufenden Datei befinden. Oder die ganzen möglichen Skripte und Grafiken auf dem eigenen Server abzulegen, damit nur noch einmal am Tag die Bewertungen abgerufen werden müssen. Das ganze geht ziemlich auf die Ladegeschwindigkeit der Seite.

comment:3 Changed 10 months ago by noRiddle

Zumindest die Mehrsprachigkeit wäre eigtl. leicht umzusetzen.
Deshalb erlaube ich mir mal das zu pushen.

Gruß,
noRiddle

comment:4 Changed 8 months ago by noRiddle

Push again :-D

Gruß,
noRiddle

comment:5 Changed 8 months ago by Tomcraft

  • Milestone set to modified-shop-2.0.5.1

comment:6 Changed 8 months ago by GTB

  • Resolution set to fixed
  • Status changed from new to closed

In 12701:

fix #1711 - revised Shopvote, including multi language support

Changed 8 months ago by Tomcraft

comment:8 Changed 7 months ago by FräuleinGarn

Hier die Fehlermeldung aus mod_warning_2020-04-18.log

Da ist ein Backslash zuviel im Pfad zur modified_api.php

[2020-04-18 23:33:54]	[warning]	[modified]	[pid:16794]	require_once(/var/www/vhosts/meinshop//var/www/vhosts/meinshop/includes/classes/modified_api.php): failed to open stream: No such file or directory in File: /var/www/vhosts/meinshop/includes/extra/application_top/application_top_end/70_shopvote.php on Line: 25	{}	{}
[2020-04-18 23:33:54]	[warning]	[modified]	[pid:16794]	Backtrace #0 - /var/www/vhosts/meinshop/includes/application_top.php called at Line 363	{}	{}
[2020-04-18 23:33:54]	[warning]	[modified]	[pid:16794]	Backtrace #1 - /var/www/vhosts/meinshop/product_info.php called at Line 25	{}	{}
Last edited 7 months ago by Tomcraft (previous) (diff)

comment:9 Changed 7 months ago by FräuleinGarn

Da ist nicht nur ein Backslash zuviel sondern der erste Teil der Pfadangabe ist doppelt

comment:10 Changed 7 months ago by Tomcraft

  • Resolution fixed deleted
  • Status changed from closed to reopened

Ja, scheint ein Fehler zu sein. Wenn ich das richtig sehe muss es in Datei "/includes/extra/application_top/application_top_end/70_shopvote.php" in Zeile 25 heißen:

      // include needed classes
      require_once (DIR_WS_CLASSES.'modified_api.php');

Anstelle von:

      // include needed classes
      require_once (DIR_FS_CATALOG.DIR_WS_CLASSES.'modified_api.php');

Denn DIR_WS_CLASSES ist laut "/includes/paths.php" bereits so zusammengesetzt:

  // classes
  define('DIR_WS_CLASSES', DIR_WS_INCLUDES . 'classes/');

Und DIR_WS_INCLUDES enthält wiedrum bereits DIR_FS_CATALOG:

  // includes
  define('DIR_WS_INCLUDES', DIR_FS_CATALOG. 'includes/');

Für den Admin gilt das nicht, denn dort enthält DIR_WS_INCLUDES nicht DIR_FS_CATALOG, also nur so:

  // includes
  define('DIR_WS_INCLUDES', 'includes/');

Wenn ich das nun also richtig sehe, dann ist der selbe Fehler auch in der "/includes/classes/afterbuy.php" vorhanden ab Zeile 190:

		if (!class_exists (xtcPrice)) {
		  require_once (DIR_FS_CATALOG.DIR_WS_CLASSES . 'xtcPrice.php');
		  $xtPrice = new xtcPrice($oData['currency'],$oData['customers_status']);
		}

Sowie an mehrere Stellen in der "/includes/modules/payment/klarna/checkout/klarnaMobile.php":

Zeile 43:

    $oAPI    = new KlarnaMobile($oKlarna, 'se', DIR_FS_CATALOG . DIR_WS_CLASSES . 'klarna/standardRegister', 'default');

Zeile 69:

        $oAPI        = new KlarnaMobile(&$oKlarna, 'se', DIR_FS_CATALOG . DIR_WS_CLASSES . 'klarna/standardRegister');

Zeile 91:

        $oAPI        = new KlarnaMobile($oKlarna, 'se', DIR_FS_CATALOG . DIR_WS_CLASSES . 'klarna/standardRegister');
Last edited 7 months ago by Tomcraft (previous) (diff)

comment:11 Changed 7 months ago by FräuleinGarn

Das hatte ich auch schon probiert abgeleitet aus dem PayPal? Plus Dateien, wo auch die modified.api eingebunden wird. Das Verhalten im Backend ist das selbe. Keine Texte sichtbar. Die Fehlermeldung mit dem doppelten Pfad und Backslash ist weg.

Dafür kommt nun

[2020-04-19 00:27:10]	[warning]	[modified]	[pid:20449]	Illegal string offset 'author' in File: /var/www/vhosts/meinshop/includes/extra/application_top/application_top_end/70_shopvote.php on Line: 35	{}	{}
[2020-04-19 00:27:10]	[warning]	[modified]	[pid:20449]	Backtrace #0 - /var/www/vhosts/meinshop/includes/application_top.php called at Line 363	{}	{}
[2020-04-19 00:27:10]	[warning]	[modified]	[pid:20449]	Backtrace #1 - /var/www/vhosts/meinshop/product_info.php called at Line 25	{}	{}
[2020-04-19 00:27:10]	[warning]	[modified]	[pid:20449]	Illegal string offset 'created' in File: /var/www/vhosts/meinshop/includes/extra/application_top/application_top_end/70_shopvote.php on Line: 36	{}	{}
[2020-04-19 00:27:10]	[warning]	[modified]	[pid:20449]	Backtrace #0 - /var/www/vhosts/meinshop/includes/application_top.php called at Line 363	{}	{}
[2020-04-19 00:27:10]	[warning]	[modified]	[pid:20449]	Backtrace #1 - /var/www/vhosts/meinshop/product_info.php called at Line 25	{}	{}
[2020-04-19 00:27:10]	[warning]	[modified]	[pid:20449]	Illegal string offset 'author' in File: /var/www/vhosts/meinshop/includes/extra/application_top/application_top_end/70_shopvote.php on Line: 41	{}	{}
[2020-04-19 00:27:10]	[warning]	[modified]	[pid:20449]	Backtrace #0 - /var/www/vhosts/meinshop/includes/application_top.php called at Line 363	{}	{}
[2020-04-19 00:27:10]	[warning]	[modified]	[pid:20449]	Backtrace #1 - /var/www/vhosts/meinshop/product_info.php called at Line 25	{}	{}
[2020-04-19 00:27:10]	[warning]	[modified]	[pid:20449]	Illegal string offset 'rating_value' in File: /var/www/vhosts/meinshop/includes/extra/application_top/application_top_end/70_shopvote.php on Line: 42	{}	{}
[2020-04-19 00:27:10]	[warning]	[modified]	[pid:20449]	Backtrace #0 - /var/www/vhosts/meinshop/includes/application_top.php called at Line 363	{}	{}
[2020-04-19 00:27:10]	[warning]	[modified]	[pid:20449]	Backtrace #1 - /var/www/vhosts/meinshop/product_info.php called at Line 25	{}	{}
[2020-04-19 00:27:10]	[warning]	[modified]	[pid:20449]	Illegal string offset 'created' in File: /var/www/vhosts/meinshop/includes/extra/application_top/application_top_end/70_shopvote.php on Line: 43	{}	{}
[2020-04-19 00:27:10]	[warning]	[modified]	[pid:20449]	Backtrace #0 - /var/www/vhosts/meinshop/includes/application_top.php called at Line 363	{}	{}
[2020-04-19 00:27:10]	[warning]	[modified]	[pid:20449]	Backtrace #1 - /var/www/vhosts/meinshop/product_info.php called at Line 25	{}	{}
[2020-04-19 00:27:10]	[warning]	[modified]	[pid:20449]	Illegal string offset 'text' in File: /var/www/vhosts/meinshop/includes/extra/application_top/application_top_end/70_shopvote.php on Line: 51	{}	{}
[2020-04-19 00:27:10]	[warning]	[modified]	[pid:20449]	Backtrace #0 - /var/www/vhosts/meinshop/includes/application_top.php called at Line 363	{}	{}
[2020-04-19 00:27:10]	[warning]	[modified]	[pid:20449]	Backtrace #1 - /var/www/vhosts/meinshop/product_info.php called at Line 25	{}	{}

comment:12 Changed 7 months ago by GTB

  • Resolution set to fixed
  • Status changed from reopened to closed

In 12707:

fix #1711 - revised Shopvote, including multi language support

Changed 7 months ago by Tomcraft

comment:13 Changed 7 months ago by GTB

In 12710:

fix #1711 - revised Shopvote, including multi language support

comment:14 Changed 7 months ago by GTB

In 12712:

fix #1711 - revised Shopvote, including multi language support

Changed 7 months ago by Tomcraft

Changed 7 months ago by Tomcraft

comment:15 Changed 7 months ago by GTB

In 12713:

fix #1711 - revised Shopvote, including multi language support

comment:16 Changed 7 months ago by GTB

In 12714:

fix #1711 - revised Shopvote, including multi language support

Changed 7 months ago by Tomcraft

Changed 7 months ago by Tomcraft

comment:17 Changed 7 months ago by GTB

In 12718:

fix #1711 - revised Shopvote, including multi language support

comment:18 Changed 7 months ago by GTB

In 12719:

fix #1711 - revised Shopvote, including multi language support

Changed 7 months ago by Tomcraft

Changed 7 months ago by Tomcraft

comment:19 Changed 7 months ago by GTB

In 12727:

fix #1711 - revised Shopvote, including multi language support

Changed 7 months ago by Tomcraft

comment:20 Changed 7 months ago by Tomcraft

  • Milestone changed from modified-shop-2.0.5.1 to modified-shop-2.0.5.2

comment:21 Changed 7 months ago by GTB

In 12752:

fix #1711 - revised Shopvote, including multi language support

Changed 7 months ago by Tomcraft

comment:22 Changed 5 weeks ago by FräuleinGarn

Seit 2.0.5.1 scheinen keine Bewertungen ohne Text mehr angezeigt zu werden. Dies können nur Bewertungen von Shopvote sein. Bitte lösen, da man sonst umsonst Geld bezahlt bei Shopvote und noch schlimmer bei Inkonsistenz der strukturierten Daten eventuell das Ranking drunter leidet.

comment:23 Changed 5 weeks ago by Tomcraft

Das wurde bereits in r12757 korrigiert, hat aber mit ShopVote? nichts zu tun, siehe: MODUL: ShopVote für Shopversion 2.x

Add Comment

Modify Ticket

Action
as closed
The resolution will be deleted. Next status will be 'reopened'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.