Opened 9 months ago

Closed 9 months ago

Last modified 9 months ago

#1683 closed Bug/Fehler (fixed)

Kommentare in SQL Queries entfernen

Reported by: Stefan May <stefan@…> Owned by: somebody
Priority: normal Milestone: modified-shop-2.0.5.0
Component: Shop Version: 2.0.4.2

Description (last modified by Tomcraft)

In Datei shoproot/includes/modules/set_account_type.php findet sich ab Zeile 14:

  $account_type_query = xtc_db_query("-- /includes/application_top.php
                                      SELECT account_type,
                                             customers_default_address_id
                                        FROM ".TABLE_CUSTOMERS."
                                       WHERE customers_id = '".(int) $_SESSION['customer_id']."'");

sowie ab Zeile 23:

    $zone_query = xtc_db_query("-- /includes/application_top.php
                            SELECT entry_country_id
                              FROM ".TABLE_ADDRESS_BOOK."
                             WHERE customers_id='".(int) $_SESSION['customer_id']."'
                               AND address_book_id='".$account_type['customers_default_address_id']."'");

Der String "-- /includes/application_top.php" sollte aus den SQL-Befehlen entfernt werden und jeder Befehl mit dem Schlüsselwort "SELECT" in der jeweils nächsten Zeile beginnen.

In Shopversion 2.0.4.2 ergeben beide SQL-Befehle durch den Fehler immer ein leeres Ergebnis, aber keine Fehlermeldung.

Attachments (0)

Change History (6)

comment:1 Changed 9 months ago by GTB

  • Resolution set to worksforme
  • Status changed from new to closed

Ich kann das leider nicht nachstellen. Zudem werden SQL Kommentare an vielen weiteren Stellen verwendet. Wir können diese Kommentare gerne entfernen, da ich nie ein Freund davon war.

comment:2 Changed 9 months ago by GTB

  • Milestone set to modified-shop-2.0.5.0

comment:4 Changed 9 months ago by Tomcraft

  • Description modified (diff)

comment:5 Changed 9 months ago by Tomcraft

  • Resolution worksforme deleted
  • Status changed from closed to reopened
  • Summary changed from Code-Fragment in SQL Query to Kommentare in SQL Queries entfernen

comment:6 Changed 9 months ago by GTB

  • Resolution set to fixed
  • Status changed from reopened to closed

In 12198:

fix #1683 - remove sql comments

comment:7 Changed 9 months ago by Tomcraft

In 12201:

fix #1683 - remove sql comments

Add Comment

Modify Ticket

Action
as closed
The resolution will be deleted. Next status will be 'reopened'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.